Patchwork [O] org-mobile agenda title

login
register
Submitter Henning Weiss
Date 2012-01-25 21:21:16
Message ID <CAKq33ucev3yTJhtRtwPP6FAG-ks9OfaCcNaudbbH859LTpEKAw@mail.gmail.com>
Download mbox | patch
Permalink /patch/1137/
State Superseded, archived
Delegated to: Bastien Guerry
Headers show

Comments

Henning Weiss - 2012-01-25 21:21:16
Hi everyone,

I have been working on a patch for
mobileorg-android<https://github.com/matburt/mobileorg-android>that
improves the displaying of the generated
agendas.org file. The problem I'm having is that TITLE: fields of all
entries are generated by concatenating the name and the matching criterion
of an entry. The issue is discussed in further details
here<https://github.com/matburt/mobileorg-android/issues/114#issuecomment-3658654>
.

I have tried to create a patch that removes the match criterions from the
generated title entry and attached it below. This could potentially break
other org-mobile clients and might not be the best way to solve this.

What would it take to include this in orgmode?

best regards,
Henning Weiss

     (and new (list "X" "SUMO" (reverse new)
Bastien Guerry - 2012-01-28 14:41:07
Hi Henning,

Henning Weiss <hdweiss@gmail.com> writes:

> I have been working on a patch for mobileorg-android that improves
> the displaying of the generated agendas.org file. The problem I'm
> having is that TITLE: fields of all entries are generated
> by concatenating the name and the matching criterion of an entry. The
> issue is discussed in further details here. 
>
> I have tried to create a patch that removes the match criterions from
> the generated title entry and attached it below. This could
> potentially break other org-mobile clients and might not be the best
> way to solve this.
>
> What would it take to include this in orgmode?

The patch looks okay to me (I read the discussion you pointed to.)

Richard, would this patch break anything on your side?

Thanks,

Patch

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 541ccc8..82320c7 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -592,7 +592,7 @@  The table of checksums is written to the file
mobile-checksums."
  (cons (list 'org-agenda-title-append
     (concat "<after>KEYS=" gkey "#" (number-to-string
       (setq cnt (1+ cnt)))
-    " TITLE: " gdesc " " match "</after>"))
+    " TITLE: " gdesc "</after>"))
       settings))
   (push (list type match settings) new)))))